Improve SQL Server connection failure diagnostics#1224
Open
ramonsmits wants to merge 1 commit into
Open
Conversation
When the sqlserver command failed to connect, the tool printed the same generic message twice and hid the real SqlException. Now: - Surface SqlException Number, State, Class, Server, and all errors in the failure message - Echo the effective connection identity (Data Source, Initial Catalog, Integrated Security, Windows identity) before probing, never secrets - Unwrap HaltException to the innermost exception when printing and dedupe repeated messages - Always write a redacted diagnostics log file (full exception chain, Password/PWD blanked) and report wrapped errors, including with --unattended - Harden --connectionStringSource parsing: trim whitespace, strip wrapping quotes, and validate each line, reporting the 1-based line number on parse failure
mauroservienti
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
sqlservercommand failed to connect, the tool printed the same generic message twice and hid the realSqlException.--unattended--connectionStringSourcelines, reporting the 1-based line number on parse failureExit codes unchanged.